[FEATURE] 회원가입 API 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
35
to
38
| @PostMapping("/register/{token}") | ||
| public ResponseEntity<AuthResponse> register(@PathVariable String token, @RequestBody @Valid RegisterRequest request) { | ||
| return userService.registerUser(request); | ||
| } |
There was a problem hiding this comment.
회원가입인것 같은데 token의 역할이 뭔지 궁금합니다.
사용자 가입을 할때는 애초애 아무정보가 없어야 하지않나 생각이 드네요.
There was a problem hiding this comment.
수정했습니다요
나중에 소셜로그인쪽 할 때 추가될 수도 있을 것 같습니다
아니면 소셜로그인 회원가입은 따로 빼야겠네요
Comment on lines
27
to
36
| User user = userRepository.save(User.builder() | ||
| .email(request.getEmail()) | ||
| .password(request.getPassword()) | ||
| .nickName(request.getNickName()) | ||
| .thumbnail(request.getThumbnail()) | ||
| .build()); | ||
|
|
||
| AuthResponse res = AuthResponse.builder() | ||
| .token(jwtTokenProvider.generateToken(user.getId(), user.getEmail(),user.getNickName(), user.getRole())) | ||
| .build(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
회원가입 API 구현